Skip to the content ForoHackers
Log inJoin

Should every build of our greyhound game ship with -Werror?

Build systemsCCompilersOpen source
#18073 · · Quote · Report

Spare Sofa, my open-source C game about trying to sit down while a greyhound is on the furniture. New port contributor can't build it because a callback ignores its width argument. Our blessed Makefile promotes every warning to an error. Apparently the dog now owns a compiler. I say keep -Werror everywhere and fix the damn callback. Come at me.

#18240 · · Quote · Report

Yes. Fair. But the compiler warning that stopped the port was real, and putting that change in our tests didn't magically fix the warning.

#18241 · · Quote · Report

entiendo las dos cosas. el perro es tuyo, la advertencia es tuya, el profe de arriba tiene treinta críos y cincuenta minutos para que el bicho se tire un pedo. ¿de verdad quieres que todos sean mantenedores?

#18242 · · Quote · Report

twelve adults, eighty minutes. I will be quoting your learning objective verbatim.

#18248 · · Quote · Report

who is setting the flags? if the packager deliberately requests strict and the project quietly strips it, now you've annoyed the other half of the same people.

#18249 · · Quote · Report

thank you. I want a normal source build to show warnings, your audited compiler matrix to fail on them, and my ability to choose strict locally when I am trying to help you.

#18250 · · Quote · Report

First cut of that switch just landed. Maintainer CI sets strict. Normal download has warnings on, no blanket Werror. Same compiler flags apart from that bit. Take it for a spin.

#18251 · · Quote · Report

En la normal he vuelto a meter SIN QUERER el width sin usar. Me avisa y sale juego. En la estricta da error. Ahora llámame paquete, pero con propiedad: estoy empaquetando.

#18252 · · Quote · Report

mine says no warnings either way. same source as your broken copy, same command you gave me. what did I miss?

#18253 · · Quote · Report

Did it compile, or did make say there was nothing to do? A flag changed on the command line doesn't by itself give a plain timestamp-based rule a newer file to look at.

#18254 · · Quote · Report

it printed EXACTLY "Nothing to be done". spent ten minutes congratulating a compiler that hadn't been to work.

#18256 · · Quote · Report

try two clean build directories with the two modes. keep both logs. don't rely on the strict test to rebuild an object that the relaxed test already made.

#18258 · · Quote · Report

lol my money was on the keyboard coming unplugged. now I'm losing actual biscuits to a Makefile.

#18260 · · Quote · Report

separate clean directories now, like timpano. I get the warning both places, an executable only in the relaxed one. the bloody dog had a cached alibi.

#18261 · · Quote · Report

Changed the CI smoke job to launch the actual release build. I can tell whether the room loaded by its state. The screen being beige is a strangely ambiguous success criterion.

#18263 · · Quote · Report

I can fix that so fast. Purple dog. I'll have him by lunch.

#18264 · · Quote · Report

do not change the dog to make your screenshot pass. I recognise this sequence of events. I have a chart.

#18276 · · Quote · Report

yesterday's old download still fails on the new compiler, right? later fix doesn't retrospectively fix a file in someone's downloads folder. what's on the project page NOW?

#18278 · · Quote · Report

Old archive kept with its date. New point release gets the switch and the actual sofa. Changed the page to link the new one. Thanks for asking a question with a discoverable answer.

#18279 · · Quote · Report

can we have the acoustic room without the sofa back as downloadable content

#18281 · · Quote · Report

La hostia el perro fantasma, lo guardé para enseñárselo a mi colega y ahora el tarball nuevo FUNCIONA. Trabajar así es imposible.

#18283 · · Quote · Report

vende el DLC por cero euros pero falla con un aviso si intentas llevártelo gratis. enciende otra ronda de debate y vives de la publicidad hasta que el perro se jubile.

#18288 · · Quote · Report

printed the empty room. wrote 'minimalist port' on the back. somebody at the cafe ACTUALLY OFFERED ME MONEY. wtf

#18306 · · Quote · Report

report from school: one of them saw the warning on purpose, rebuilt strict, and fixed the callback. three went straight on to put the dog on the coffee table. twelve people got to pick. nobody asked me for a toolchain update.

#18308 · · Quote · Report

¿y ganó alguien al perro o sigue siendo un simulador de alquiler?

#18310 · · Quote · Report

he got up for the doorbell. whole room yelled SIT DOWN at the player. twelve adults perfectly qualified to own one sofa between them.

#18351 · · Quote · Report

My mother got the new download. She says the mark on the left is NOT coffee. She would like people to stop zooming in on her sofa.

#18354 · · Quote · Report

pues ahora sí que parece una ardilla.

You are not logged in, so this goes up anonymously: no account, no name and no address is stored with it, and it may carry no link and no image. Log in or join to post under your name. Our web server's logs keep the address and time of every request for up to 14 days; to keep yours out of them, use Tor. To reach the staff in confidence, use the drop. Sign as a returning source (a key kept only in this browser)

Sending takes a few seconds here: your browser first works out a proof of work against spam.

Reply